aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMattias Andrée <maandree@operamail.com>2014-05-20 04:38:26 +0200
committerMattias Andrée <maandree@operamail.com>2014-05-20 04:38:26 +0200
commit3406003a3747fda37efb4f0f7d4749e91201935d (patch)
treee26d0e6abdeeab7416f0048b47246c696c44e959
parentModify mds-server to use mds-base (some regression...) (diff)
downloadmds-3406003a3747fda37efb4f0f7d4749e91201935d.tar.gz
mds-3406003a3747fda37efb4f0f7d4749e91201935d.tar.bz2
mds-3406003a3747fda37efb4f0f7d4749e91201935d.tar.xz
m doc
Signed-off-by: Mattias Andrée <maandree@operamail.com>
-rw-r--r--src/mds-base.h4
-rw-r--r--src/mds-server/reexec.c4
2 files changed, 8 insertions, 0 deletions
diff --git a/src/mds-base.h b/src/mds-base.h
index e92e73e..5aa9463 100644
--- a/src/mds-base.h
+++ b/src/mds-base.h
@@ -192,6 +192,10 @@ extern int marshal_server(char* state_buf);
*
* Unmarshal server implementation specific data and update the servers state accordingly
*
+ * On critical failure the program should `abort()` or exit by other means.
+ * That is, do not let `reexec_failure_recover` run successfully, if it unrecoverable
+ * error has occurred or one severe enough that it is better to simply respawn.
+ *
* @param state_buf The marshalled data that as not been read already
* @return Non-zero on error
*/
diff --git a/src/mds-server/reexec.c b/src/mds-server/reexec.c
index 6667a73..48dc53e 100644
--- a/src/mds-server/reexec.c
+++ b/src/mds-server/reexec.c
@@ -163,6 +163,10 @@ static size_t unmarshal_remapper(size_t old)
/**
* Unmarshal server implementation specific data and update the servers state accordingly
*
+ * On critical failure the program should `abort()` or exit by other means.
+ * That is, do not let `reexec_failure_recover` run successfully, if it unrecoverable
+ * error has occurred or one severe enough that it is better to simply respawn.
+ *
* @param state_buf The marshalled data that as not been read already
* @return Non-zero on error
*/