From 3406003a3747fda37efb4f0f7d4749e91201935d Mon Sep 17 00:00:00 2001 From: Mattias Andrée Date: Tue, 20 May 2014 04:38:26 +0200 Subject: m doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mattias Andrée --- src/mds-base.h | 4 ++++ src/mds-server/reexec.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/mds-base.h b/src/mds-base.h index e92e73e..5aa9463 100644 --- a/src/mds-base.h +++ b/src/mds-base.h @@ -192,6 +192,10 @@ extern int marshal_server(char* state_buf); * * Unmarshal server implementation specific data and update the servers state accordingly * + * On critical failure the program should `abort()` or exit by other means. + * That is, do not let `reexec_failure_recover` run successfully, if it unrecoverable + * error has occurred or one severe enough that it is better to simply respawn. + * * @param state_buf The marshalled data that as not been read already * @return Non-zero on error */ diff --git a/src/mds-server/reexec.c b/src/mds-server/reexec.c index 6667a73..48dc53e 100644 --- a/src/mds-server/reexec.c +++ b/src/mds-server/reexec.c @@ -163,6 +163,10 @@ static size_t unmarshal_remapper(size_t old) /** * Unmarshal server implementation specific data and update the servers state accordingly * + * On critical failure the program should `abort()` or exit by other means. + * That is, do not let `reexec_failure_recover` run successfully, if it unrecoverable + * error has occurred or one severe enough that it is better to simply respawn. + * * @param state_buf The marshalled data that as not been read already * @return Non-zero on error */ -- cgit v1.2.3-70-g09d2