go through todo list

Signed-off-by: Mattias Andrée <m@maandree.se>

2 files changed, 4 insertions, 10 deletions

diff --git a/TODO b/TODO
index 2801249..f846530 100644
--- a/TODO
+++ b/TODO
@@ -13,20 +13,16 @@ https://github.com/jonls/redshift/pull/788	redshift-gtk-desktop.in: Remove Start
 https://github.com/jonls/redshift/pull/864	Fix apparmor config.
 https://github.com/jonls/redshift/issues/385	Patch: fix broken temperature setting on Quartz
 
-https://github.com/jonls/redshift/issues/154	Configurable duration between gamma adjustments
 https://github.com/jonls/redshift/issues/155	Redshift 1.10 - Clicking Icon Off - Screen Doesn't Return Full Brightness
 https://github.com/jonls/redshift/issues/170	Can't see right icons in Linux Mint 17 Cinnamon
 https://github.com/jonls/redshift/issues/182	Status icon not visible on Ubuntu without Appindicator package
 https://github.com/jonls/redshift/issues/217	redshift appears to stop working after resume from suspend
 https://github.com/jonls/redshift/issues/219	Linux Mint Xfce 17.1: redshift-gtk does not show in panel
 https://github.com/jonls/redshift/issues/253	It doesn't kill the process after I logout.
-https://github.com/jonls/redshift/issues/254	Weird unstability issue
-https://github.com/jonls/redshift/issues/316	kde + 32gb ram + haswell igpu = flicker
 https://github.com/jonls/redshift/issues/337	No support for multiple monitors on OS X
 https://github.com/jonls/redshift/issues/436	Adjust backlight of external monitors
 https://github.com/jonls/redshift/issues/501	Icons Not Appearing On XFCE
 https://github.com/jonls/redshift/issues/516	redshift-gtk consumes 100% CPU if denied geoclue (or cannot find geoclue?)
-https://github.com/jonls/redshift/issues/686	Can we somehow prevent redshift-gtk.desktop from being added to ~/.config/autostart ?
 https://github.com/jonls/redshift/issues/708	Apparmor profile blocks config file if XDG_CONFIG_HOME is set
 https://github.com/jonls/redshift/issues/713	Not working on 3rd plug n play screen in Linux Mint 19.1
 https://github.com/jonls/redshift/issues/723	Tray icon disappeared [still unsolved, please look – new information!]
@@ -35,13 +31,9 @@ https://github.com/jonls/redshift/issues/735	redshift black screens Ubuntu 18.04
 https://github.com/jonls/redshift/issues/737	Not working on external monitors (ubuntu 18.04 with i3wm)
 https://github.com/jonls/redshift/issues/746	Redshift restarts when switching to an i3 workspace with a java application
 https://github.com/jonls/redshift/issues/756	Add a way to check whether redshift is currently enabled and add a way to disable/enable
-https://github.com/jonls/redshift/issues/759	Enabling monitor requires loading its gamma ramps, but Redshift resets them
 https://github.com/jonls/redshift/issues/783	Allow icon click to toggle redshift when AppIndicator3 is used
 https://github.com/jonls/redshift/issues/784	Redshift-gtk icon is blank
-https://github.com/jonls/redshift/issues/789	Redshift uses the deleted file /memfd:pulseaudio
-https://github.com/jonls/redshift/issues/813	Start Redshift on ubuntu HIRSUTE
 https://github.com/jonls/redshift/issues/839	Allow hooks to transition smoothly
-https://github.com/jonls/redshift/issues/842	Cannot import _gi [circular dependency error when running redshift gt ]
 https://github.com/jonls/redshift/issues/849	Windows blinking / flickering of "classic" Windows menus
 https://github.com/jonls/redshift/issues/862	(redshift-gtk:6420): Gdk-CRITICAL
 https://github.com/jonls/redshift/issues/891	Is it working ? I can't tell.a
@@ -99,3 +91,4 @@ print, for use by frontends, what mode redshift was started in
 [Windows] Make sure extended paths are supported
 Document the "geofile" location provider
 Document the "timezone" location provider
+Add value to SIGUSR2 to force reapply gamma ramps
diff --git a/redshift/redshift.c b/redshift/redshift.c
index 5bc172e..3086a83 100644
--- a/redshift/redshift.c
+++ b/redshift/redshift.c
@@ -312,6 +312,7 @@ run_continual_mode(void)
 		if (disable && !done) {
 			disabled ^= 1;
 			disable = 0;
+			/* TODO if `!disabled`, reload gamma ramps and store as saved gamma ramps */
 		}
 		if (exiting) {
 			disabled = 1;
@@ -412,9 +413,9 @@ run_continual_mode(void)
 			break;
 
 		/* Adjust temperature and sleep */
-		if (method->apply(method_state, &colour, preserve_gamma) < 0)
+		if (method->apply(method_state, &colour, preserve_gamma) < 0) /* TODO (optionlly) only if colour changed */
 			eprintf(_("Temperature adjustment failed."));
-		delay = fade_length ? SLEEP_DURATION_SHORT : SLEEP_DURATION;
+		delay = fade_length ? SLEEP_DURATION_SHORT : SLEEP_DURATION /* TODO (optionally) try to be more smart */;
 #ifndef WINDOWS
 		location_fd = scheme.type == SOLAR_SCHEME ? provider->get_fd(provider_state) : -1;
 		if (location_fd >= 0)