aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMattias Andrée <maandree@operamail.com>2015-08-24 01:43:09 +0200
committerMattias Andrée <maandree@operamail.com>2015-08-24 01:43:09 +0200
commit151a0940438357886e1faae4e807dfaadcf55069 (patch)
treeeebfa4b3eff1dad85c13ea5c9263f24bd46273ce
parentm (diff)
downloadmds-151a0940438357886e1faae4e807dfaadcf55069.tar.gz
mds-151a0940438357886e1faae4e807dfaadcf55069.tar.bz2
mds-151a0940438357886e1faae4e807dfaadcf55069.tar.xz
m todo + implement get-colour
Signed-off-by: Mattias Andrée <maandree@operamail.com>
-rw-r--r--TODO7
-rw-r--r--src/mds-colour.c42
2 files changed, 45 insertions, 4 deletions
diff --git a/TODO b/TODO
index c6884df..13c1f4c 100644
--- a/TODO
+++ b/TODO
@@ -4,6 +4,13 @@ documentation:
Texinfo manual should use declarative mood
Source code documentation should use imperative mood
+All responses should have a special header identifying
+their origin so that they can be observed or modified.
+The value of this head should be the value of the Command
+header in the query. For example if a server receives
+`Command: X`, it should respond with `Origin command: X`,
+or something like that.
+
Missing servers:
xmds wmds mmds mdsx
diff --git a/src/mds-colour.c b/src/mds-colour.c
index 57fa1ee..5695dc7 100644
--- a/src/mds-colour.c
+++ b/src/mds-colour.c
@@ -429,15 +429,49 @@ int handle_list_colours(const char* recv_client_id, const char* recv_message_id,
*/
int handle_get_colour(const char* recv_client_id, const char* recv_message_id, const char* recv_name)
{
+ colour_t colour;
+ ssize_t length;
+ char* temp;
+
if (strequals(recv_client_id, "0:0"))
return eprint("got a query from an anonymous client, ignoring."), 0;
if (recv_name == NULL)
return send_error(recv_client_id, recv_message_id, 0, EPROTO, NULL);
- /* TODO send colour, "not defined" if missing */
+ if (!colour_list_get(&colours, recv_name, &colour))
+ return send_error(recv_client_id, recv_message_id, 1, -1, "not defined");
- return 0;
+ snprintf(NULL, 0,
+ "To: %s\n"
+ "In response to: %s\n"
+ "Bytes: %i\n"
+ "Red: %"PRIu64"\n"
+ "Green; %"PRIu64"\n"
+ "Blue: %"PRIu64"\n"
+ "\n%zn",
+ recv_client_id, recv_message_id, colour.bytes,
+ colour.red, colour.green, colour.blue, &length);
+
+ if ((size_t)length > send_buffer_size)
+ {
+ if (yrealloc(temp, send_buffer, (size_t)length, char))
+ return -1;
+ send_buffer_size = (size_t)length;
+ }
+
+ sprintf(send_buffer,
+ "To: %s\n"
+ "In response to: %s\n"
+ "Bytes: %i\n"
+ "Red: %"PRIu64"\n"
+ "Green; %"PRIu64"\n"
+ "Blue: %"PRIu64"\n"
+ "\n",
+ recv_client_id, recv_message_id, colour.bytes,
+ colour.red, colour.green, colour.blue);
+
+ return full_send(send_buffer, (size_t)length);
}
@@ -491,10 +525,10 @@ int handle_set_colour(const char* recv_name, const char* recv_remove, const char
if (strict_atou64(recv_blue, &(colour.blue), 0, limit))
return eprint("got an invalid value on the Blue-header, ignoring."), 0;
- return set_colour(recv_name, &colour);
+ return set_colour(recv_name, &colour); /* TODO broadcast update */
}
else
- colour_list_remove(&colours, recv_name);
+ colour_list_remove(&colours, recv_name); /* TODO broadcast update */
return 0;
}