aboutsummaryrefslogtreecommitdiffstats
path: root/libexec_pipe_commandsvn.c
diff options
context:
space:
mode:
Diffstat (limited to 'libexec_pipe_commandsvn.c')
-rw-r--r--libexec_pipe_commandsvn.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/libexec_pipe_commandsvn.c b/libexec_pipe_commandsvn.c
index d6aa1d5..8b0dbe2 100644
--- a/libexec_pipe_commandsvn.c
+++ b/libexec_pipe_commandsvn.c
@@ -59,6 +59,9 @@ pipe_two_commands(enum libexec_pipe how, struct libexec_command *left, struct li
}
right->plumings[right->nplumings - 1].type = LIBEXEC_PLUMING_PIPE;
+ /* TOOD should `fds[0]` be closed from `left`, and `fds[1]` close from `right`
+ * (isn't this a problem in general with LIBEXEC_PLUMING_PIPE) */
+
/* pluming shall be at the front */
tmp = left->plumings[left->nplumings - 1];
memcpy(&left->plumings[1], &left->plumings[0], (left->nplumings - 1) * sizeof(*left->plumings));