aboutsummaryrefslogtreecommitdiffstats
path: root/libexec_putenvf_append.c
diff options
context:
space:
mode:
authorMattias Andrée <maandree@kth.se>2024-05-05 17:56:50 +0200
committerMattias Andrée <maandree@kth.se>2024-05-05 17:59:12 +0200
commit924f443d62bfabf8761da31ed890791d5893463a (patch)
treeaa544535fca95a653844aea8d233b2450246d88a /libexec_putenvf_append.c
parentFirst commit (diff)
downloadlibexec-924f443d62bfabf8761da31ed890791d5893463a.tar.gz
libexec-924f443d62bfabf8761da31ed890791d5893463a.tar.bz2
libexec-924f443d62bfabf8761da31ed890791d5893463a.tar.xz
Remove libexec_init_command, doc stuff, make functions inline, and fix a bug
libexec_init_command was a huge oversight, it cannot be used as it would set .library_version to the libraries version of LIBEXEC_VERSION rather than the application's; instead LIBEXEC_COMMAND_INIT should be used. Signed-off-by: Mattias Andrée <maandree@kth.se>
Diffstat (limited to 'libexec_putenvf_append.c')
-rw-r--r--libexec_putenvf_append.c15
1 files changed, 3 insertions, 12 deletions
diff --git a/libexec_putenvf_append.c b/libexec_putenvf_append.c
index 8ceb806..bdfa7fc 100644
--- a/libexec_putenvf_append.c
+++ b/libexec_putenvf_append.c
@@ -3,16 +3,7 @@
#ifndef TEST
-int
-libexec_putenvf_append(struct libexec_command *cmd, const char *fmt, ...)
-{
- int ret;
- va_list args;
- va_start(args, fmt);
- ret = libexec_vputenvf_append(cmd, fmt, args);
- va_end(args);
- return ret;
-}
+extern inline int libexec_putenvf_append(struct libexec_command *, const char *, ...);
#else
@@ -28,7 +19,7 @@ main(void)
ASSERT_EQ_INT(libexec_putenvf_append(NULL, "X=Y"), -1);
ASSERT_EQ_INT(errno, EINVAL);
- libexec_init_command(&cmd);
+ cmd = LIBEXEC_COMMAND_INIT;
memcpy(&ref, &cmd, sizeof(cmd));
ASSERT_ZERO(libexec_clear_environ(&cmd));
@@ -126,7 +117,7 @@ main(void)
libexec_destroy_command(&cmd);
- libexec_init_command(&cmd);
+ cmd = LIBEXEC_COMMAND_INIT;
env = environ;
environ = calloc(2, sizeof(*environ));
ASSERT_NOT_NULL(environ);