diff options
| author | Mattias Andrée <maandree@kth.se> | 2024-05-05 17:56:50 +0200 |
|---|---|---|
| committer | Mattias Andrée <maandree@kth.se> | 2024-05-05 17:59:12 +0200 |
| commit | 924f443d62bfabf8761da31ed890791d5893463a (patch) | |
| tree | aa544535fca95a653844aea8d233b2450246d88a /libexec_pipe_commandsvn.c | |
| parent | First commit (diff) | |
| download | libexec-924f443d62bfabf8761da31ed890791d5893463a.tar.gz libexec-924f443d62bfabf8761da31ed890791d5893463a.tar.bz2 libexec-924f443d62bfabf8761da31ed890791d5893463a.tar.xz | |
libexec_init_command was a huge oversight, it cannot be used
as it would set .library_version to the libraries version of
LIBEXEC_VERSION rather than the application's; instead
LIBEXEC_COMMAND_INIT should be used.
Signed-off-by: Mattias Andrée <maandree@kth.se>
Diffstat (limited to 'libexec_pipe_commandsvn.c')
| -rw-r--r-- | libexec_pipe_commandsvn.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libexec_pipe_commandsvn.c b/libexec_pipe_commandsvn.c index d6aa1d5..8b0dbe2 100644 --- a/libexec_pipe_commandsvn.c +++ b/libexec_pipe_commandsvn.c @@ -59,6 +59,9 @@ pipe_two_commands(enum libexec_pipe how, struct libexec_command *left, struct li } right->plumings[right->nplumings - 1].type = LIBEXEC_PLUMING_PIPE; + /* TOOD should `fds[0]` be closed from `left`, and `fds[1]` close from `right` + * (isn't this a problem in general with LIBEXEC_PLUMING_PIPE) */ + /* pluming shall be at the front */ tmp = left->plumings[left->nplumings - 1]; memcpy(&left->plumings[1], &left->plumings[0], (left->nplumings - 1) * sizeof(*left->plumings)); |