diff options
| -rw-r--r-- | common.h | 2 | ||||
| -rw-r--r-- | internal-linux.h | 4 | ||||
| -rw-r--r-- | libaxl.h | 4 | ||||
| -rw-r--r-- | libaxl/requests.h | 4 | ||||
| -rw-r--r-- | libaxl_connect.c | 8 | ||||
| -rw-r--r-- | libaxl_connect_without_handshake.c | 2 | ||||
| -rw-r--r-- | libaxl_receive.c | 2 | ||||
| -rw-r--r-- | libaxl_send_handshake.c | 4 | ||||
| -rw-r--r-- | libaxl_send_request.c | 2 |
9 files changed, 16 insertions, 16 deletions
@@ -78,7 +78,7 @@ struct libaxl_connection { int fd; uint16_t last_seqnum; LIBAXL_CONNECTION_RWLOCK; - LIBAXL_CONTEXT *pending_out; /* TODO can _Atomic be used instead of mutex */ + LIBAXL_CONTEXT *pending_out; /* XXX can _Atomic be used instead of mutex */ size_t in_progress; size_t in_buf_size; char *in_buf; diff --git a/internal-linux.h b/internal-linux.h index 6a4103f..6e6e380 100644 --- a/internal-linux.h +++ b/internal-linux.h @@ -26,7 +26,7 @@ _Static_assert(sizeof(MUTEX) == sizeof(uint32_t)); do {\ atomic_store(&(MUTEX), 0);\ if (syscall(SYS_futex, &(MUTEX), FUTEX_PRIVATE_FLAG | FUTEX_WAKE, INT_MAX, NULL, 0, 0) < 0) {\ - /* TODO handle of error in _UNLOCK */\ + /* XXX handle of error in _UNLOCK */\ abort();\ }\ } while (0) @@ -34,7 +34,7 @@ _Static_assert(sizeof(MUTEX) == sizeof(uint32_t)); #define _WAIT(MUTEX)\ do {\ if (syscall(SYS_futex, &(MUTEX), FUTEX_PRIVATE_FLAG | FUTEX_WAIT, 1, NULL, 0, 0) < 0) {\ - /* TODO handle of error in _WAIT */\ + /* XXX handle of error in _WAIT */\ abort();\ }\ } while (0) @@ -14,7 +14,7 @@ /** * Opaque structure for connection to the X display server */ -typedef struct libaxl_connection LIBAXL_CONNECTION; /* TODO man */ +typedef struct libaxl_connection LIBAXL_CONNECTION; /* TODO man(makefile) */ /** * Opaque structure that wraps LIBAXL_CONNECTION with @@ -22,7 +22,7 @@ typedef struct libaxl_connection LIBAXL_CONNECTION; /* TODO man */ * the same time shall access the display server * via a unique LIBAXL_CONTEXT */ -typedef struct libaxl_context LIBAXL_CONTEXT; /* TODO man */ +typedef struct libaxl_context LIBAXL_CONTEXT; /* TODO man(makefile) */ #include "libaxl/types.h" #include "libaxl/consts.h" diff --git a/libaxl/requests.h b/libaxl/requests.h index e5f23a8..d6fa0ba 100644 --- a/libaxl/requests.h +++ b/libaxl/requests.h @@ -1433,7 +1433,7 @@ struct libaxl_request_no_operation { uint16_t request_length; }; -union libaxl_request { /* TODO man page */ +union libaxl_request { /* TODO man(makefile) */ struct { uint8_t opcode; uint8_t __data; @@ -1442,7 +1442,7 @@ union libaxl_request { /* TODO man page */ # include "requests-structs.h" }; -union libaxl_request_const_ptr { /* TODO man page */ +union libaxl_request_const_ptr { /* TODO man(makefile) */ const void *as_voidptr; const union libaxl_request *as_union; # include "requests-ptr-structs.h" diff --git a/libaxl_connect.c b/libaxl_connect.c index 27b89e1..737ff46 100644 --- a/libaxl_connect.c +++ b/libaxl_connect.c @@ -142,10 +142,10 @@ get_auth(const char *xauthfile, int sockfd, const char *host, const char *protoc family = FamilyLocal; break; case AF_INET: - family = FamilyInternet; /* TODO */ + family = FamilyInternet; /* XXX */ return 0; case AF_INET6: - family = FamilyInternet6; /* TODO */ + family = FamilyInternet6; /* XXX */ return 0; default: return 0; @@ -259,8 +259,8 @@ libaxl_connect(const char *restrict display, char **restrict reasonp) r = libaxl_receive_handshake(ctx, &major, &minor, reasonp, MSG_NOSIGNAL); switch (r) { - case LIBAXL_HANDSHAKE_FAILED: /* TODO */ - case LIBAXL_HANDSHAKE_AUTHENTICATE: /* TODO */ + case LIBAXL_HANDSHAKE_FAILED: /* XXX */ + case LIBAXL_HANDSHAKE_AUTHENTICATE: /* XXX */ abort(); break; diff --git a/libaxl_connect_without_handshake.c b/libaxl_connect_without_handshake.c index 5a4d1d8..ca4fbed 100644 --- a/libaxl_connect_without_handshake.c +++ b/libaxl_connect_without_handshake.c @@ -7,7 +7,7 @@ connect_tcp_ip(const char *host, int display) uint16_t port = libaxl_get_tcp_port(display); int fd; - abort(); /* TODO */ + abort(); /* XXX */ setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &(int){1}, sizeof(int)); setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &(int){1}, sizeof(int)); diff --git a/libaxl_receive.c b/libaxl_receive.c index 80719bd..a4c05dc 100644 --- a/libaxl_receive.c +++ b/libaxl_receive.c @@ -274,7 +274,7 @@ calculate_struct_size(const char *fmt, size_t *alignmentp) } } -/* TODO make it possible to prefetch pending messages */ +/* XXX make it possible to prefetch pending messages */ int libaxl_receive(LIBAXL_CONTEXT *restrict ctx, union libaxl_input *restrict msgp, int flags) { diff --git a/libaxl_send_handshake.c b/libaxl_send_handshake.c index 836cec9..99966fd 100644 --- a/libaxl_send_handshake.c +++ b/libaxl_send_handshake.c @@ -32,7 +32,7 @@ libaxl_send_handshake(LIBAXL_CONTEXT *restrict ctx, const char *auth_name, size_ conn->info.protocol_version_major = LIBAXL_PROTOCOL_VERSION_MAJOR; conn->info.protocol_version_minor = LIBAXL_PROTOCOL_VERSION_MINOR; conn->info.protocol_version = LIBAXL_PROTOCOL_VERSION; - conn->info.protocol_byte_order = LIBAXL_MSB_FIRST; /* TODO Use LIBAXL_LSB_FIRST if preferable */ + conn->info.protocol_byte_order = LIBAXL_MSB_FIRST; /* XXX Use LIBAXL_LSB_FIRST if preferable */ RUNLOCK_CONNECTION_SEND(conn); if (pending) { liberror_save_backtrace(NULL); @@ -68,7 +68,7 @@ libaxl_send_handshake(LIBAXL_CONTEXT *restrict ctx, const char *auth_name, size_ ctx->out_buf_size = len; } - buf[o++] = 'B'; /* TODO Use 'l' (LSB first) if preferable */ + buf[o++] = 'B'; /* XXX Use 'l' (LSB first) if preferable */ buf[o++] = 0; *(uint16_t *)&buf[o] = htons(LIBAXL_PROTOCOL_VERSION_MAJOR); o += 2; diff --git a/libaxl_send_request.c b/libaxl_send_request.c index 0e96177..b8d9146 100644 --- a/libaxl_send_request.c +++ b/libaxl_send_request.c @@ -166,7 +166,7 @@ send_all(int fd, const void *restrict data, size_t n, int flags, size_t *restric return 0; } -/* TODO make it possible to send multiple request in the same syscall */ +/* XXX make it possible to send multiple request in the same syscall */ int libaxl_send_request(LIBAXL_CONTEXT *restrict ctx, union libaxl_request_const_ptr request, int flags, uint16_t *restrict seqnump) { |