diff options
| author | Mattias Andrée <maandree@operamail.com> | 2014-03-07 16:34:55 +0100 |
|---|---|---|
| committer | Mattias Andrée <maandree@operamail.com> | 2014-03-07 16:34:55 +0100 |
| commit | 759397b9f33450a03e76adb40ed09331e31e37e0 (patch) | |
| tree | c069f9bca4711bbb4ea404c4de261cd2b281796d /src/join.py | |
| parent | Condition.notify only does nothing if no thread is waiting (diff) | |
| download | join-python-759397b9f33450a03e76adb40ed09331e31e37e0.tar.gz join-python-759397b9f33450a03e76adb40ed09331e31e37e0.tar.bz2 join-python-759397b9f33450a03e76adb40ed09331e31e37e0.tar.xz | |
fix ordered join and add test
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Diffstat (limited to 'src/join.py')
| -rw-r--r-- | src/join.py | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/join.py b/src/join.py index 7d4be9f..71acea5 100644 --- a/src/join.py +++ b/src/join.py @@ -144,16 +144,18 @@ def ordered_join(*f_groups): to join-calculus) by those invocations (as a list of not exactly one fragement) ''' condition = threading.Condition() - rc = None + rc, done = None, False index = 0 for f_group in f_groups: def join_(fs, index): + nonlocal rc, done, condition params = join(*fs) - already_done = rc is not None + already_done = done if not already_done: condition.acquire() - if rc is None: - params = (index, rc) + if not done: + rc = (index, params) + done = True condition.notify() condition.release() else: @@ -167,7 +169,8 @@ def ordered_join(*f_groups): threading.Thread(target = join_, args = (f_group, index)).start() index += 1 condition.acquire() - condition.wait() + if not done: + condition.wait() condition.release() return rc |
