From 54d7f9ff1c9c2e4a0b6a8957269285d6b9c8b37d Mon Sep 17 00:00:00 2001 From: Jon Lund Steffensen Date: Wed, 30 Mar 2011 22:09:25 +0200 Subject: w32gdi: Remember to release the DC handle on error. Add comment on failure of SetDeviceGammaRamp(). --- src/gamma-w32gdi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/gamma-w32gdi.c') diff --git a/src/gamma-w32gdi.c b/src/gamma-w32gdi.c index c5f760e..7ea8f42 100644 --- a/src/gamma-w32gdi.c +++ b/src/gamma-w32gdi.c @@ -144,6 +144,7 @@ w32gdi_set_temperature(w32gdi_state_t *state, int temp, float gamma[3]) WORD *gamma_ramps = malloc(3*GAMMA_RAMP_SIZE*sizeof(WORD)); if (gamma_ramps == NULL) { perror("malloc"); + ReleaseDC(NULL, hDC); return -1; } @@ -157,8 +158,12 @@ w32gdi_set_temperature(w32gdi_state_t *state, int temp, float gamma[3]) /* Set new gamma ramps */ r = SetDeviceGammaRamp(hDC, gamma_ramps); if (!r) { - fputs(_("Unable to set gamma ramps.\n"), stderr); + /* TODO it happens that SetDeviceGammaRamp returns FALSE on + occasions where the adjustment seems to be successful. + Does this only happen with multiple monitors connected? */ + fputs(_("Unable to set gamma ramps.\n"), stderr);s free(gamma_ramps); + ReleaseDC(NULL, hDC); return -1; } -- cgit v1.2.3-70-g09d2