Cleanup and fix bug in ztrunc

Signed-off-by: Mattias Andrée <maandree@kth.se>

1 files changed, 12 insertions, 20 deletions

diff --git a/src/zxor.c b/src/zxor.c
index 26e5b59..74cda0c 100644
--- a/src/zxor.c
+++ b/src/zxor.c
@@ -1,9 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include "internals"
 
-#include <string.h>
-#include <stdlib.h>
-
 
 void
 zxor(z_t a, z_t b, z_t c)
@@ -11,46 +8,41 @@ zxor(z_t a, z_t b, z_t c)
 	size_t n, m;
 
 	if (zzero(b)) {
-		if (zzero(c)) {
+		if (zzero(c))
 			SET_SIGNUM(a, 0);
-		} else {
-			if (a != c)
-				zset(a, c);
-		}
+		else
+			SET(a, c);
 		return;
 	} else if (zzero(c)) {
-		if (a != b)
-			zset(a, b);
+		SET(a, b);
 		return;
 	}
 
-	m = b->used > c->used ? b->used : c->used;
+	m = MAX(b->used, c->used);
 	n = b->used + c->used - m;
 
-	if (n == m && !memcmp(b->chars, c->chars, m * sizeof(*(b->chars)))) {
+	if (n == m && !zmemcmp(b->chars, c->chars, m)) {
 		SET_SIGNUM(a, 0);
 		return;
 	}
 
-	if (a->alloced < m) {
-		a->alloced = m;
-		a->chars = realloc(a->chars, m * sizeof(*(a->chars)));
-	}
+	if (a->alloced < m)
+		zahl_realloc(a, m);
 
 	if (a == b) {
-		memcpy(a->chars + n, m == b->used ? b->chars : c->chars, (m - n) * sizeof(*(a->chars)));
+		zmemcpy(a->chars + n, m == b->used ? b->chars : c->chars, m - n);
 		while (n--)
 			a->chars[n] ^= c->chars[n];
 	} else if (a == c) {
-		memcpy(a->chars + n, m == b->used ? b->chars : c->chars, (m - n) * sizeof(*(a->chars)));
+		zmemcpy(a->chars + n, m == b->used ? b->chars : c->chars, m - n);
 		while (n--)
 			a->chars[n] ^= b->chars[n];
 	} else if (m == b->used) {
-		memcpy(a->chars, b->chars, m * sizeof(*(a->chars)));
+		zmemcpy(a->chars, b->chars, m);
 		while (n--)
 			a->chars[n] ^= c->chars[n];
 	} else {
-		memcpy(a->chars, c->chars, m * sizeof(*(a->chars)));
+		zmemcpy(a->chars, c->chars, m);
 		while (n--)
 			a->chars[n] ^= b->chars[n];
 	}