From 7e0c39492a784f40f0fe0aa63e35b774dc7a4820 Mon Sep 17 00:00:00 2001 From: Mattias Andrée Date: Thu, 24 Apr 2014 08:23:41 +0200 Subject: enable more warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mattias Andrée --- Makefile | 17 +++++++++++------ src/passphrase.c | 4 ++-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index f854536..002d37c 100644 --- a/Makefile +++ b/Makefile @@ -46,12 +46,17 @@ OPTIONS ?= # Optimisation settings for C code compilation OPTIMISE ?= -Os # Warnings settings for C code compilation -WARN = -Wall -Wextra -pedantic -Wdouble-promotion -Wformat=2 -Winit-self -Wmissing-include-dirs \ - -Wfloat-equal -Wmissing-prototypes -Wmissing-declarations -Wtrampolines -Wnested-externs \ - -Wno-variadic-macros -Wdeclaration-after-statement -Wundef -Wpacked -Wunsafe-loop-optimizations \ - -Wbad-function-cast -Wwrite-strings -Wlogical-op -Wstrict-prototypes -Wold-style-definition \ - -Wvector-operation-performance -Wstack-protector -Wunsuffixed-float-constants -Wcast-align \ - -Wsync-nand -Wshadow -Wredundant-decls -Winline -Wcast-qual -Wsign-conversion -Wstrict-overflow +WARN = -Wall -Wextra -pedantic -Wdouble-promotion -Wformat=2 -Winit-self -Wmissing-include-dirs \ + -Wtrampolines -Wfloat-equal -Wshadow -Wmissing-prototypes -Wmissing-declarations \ + -Wredundant-decls -Wnested-externs -Winline -Wno-variadic-macros -Wsync-nand \ + -Wunsafe-loop-optimizations -Wcast-align -Wstrict-overflow -Wdeclaration-after-statement \ + -Wundef -Wbad-function-cast -Wcast-qual -Wwrite-strings -Wlogical-op -Waggregate-return \ + -Wstrict-prototypes -Wold-style-definition -Wpacked -Wvector-operation-performance \ + -Wunsuffixed-float-constants -Wsuggest-attribute=const -Wsuggest-attribute=noreturn \ + -Wsuggest-attribute=pure -Wsuggest-attribute=format -Wnormalized=nfkc -Wconversion \ + -fstrict-aliasing -fstrict-overflow -fipa-pure-const -ftree-vrp -fstack-usage \ + -funsafe-loop-optimizations + # The C standard for C code compilation STD = gnu99 # C preprocessor flags diff --git a/src/passphrase.c b/src/passphrase.c index dd0206c..f1ce7b7 100644 --- a/src/passphrase.c +++ b/src/passphrase.c @@ -309,9 +309,9 @@ char* passphrase_read(void) } if ((c & 0xC0) != 0x80) fputc('*', stderr); - *(rc + len++) = c; + *(rc + len++) = (char)c; #else - *(rc + len++) = c; + *(rc + len++) = (char)c; #endif xflush(); -- cgit v1.2.3-70-g09d2