From 924f443d62bfabf8761da31ed890791d5893463a Mon Sep 17 00:00:00 2001 From: Mattias Andrée Date: Sun, 5 May 2024 17:56:50 +0200 Subject: Remove libexec_init_command, doc stuff, make functions inline, and fix a bug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit libexec_init_command was a huge oversight, it cannot be used as it would set .library_version to the libraries version of LIBEXEC_VERSION rather than the application's; instead LIBEXEC_COMMAND_INIT should be used. Signed-off-by: Mattias Andrée --- libexec_putenvf_noreplace.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) (limited to 'libexec_putenvf_noreplace.c') diff --git a/libexec_putenvf_noreplace.c b/libexec_putenvf_noreplace.c index bcde8a2..f1b4140 100644 --- a/libexec_putenvf_noreplace.c +++ b/libexec_putenvf_noreplace.c @@ -3,16 +3,7 @@ #ifndef TEST -int -libexec_putenvf_noreplace(struct libexec_command *cmd, const char *fmt, ...) -{ - int ret; - va_list args; - va_start(args, fmt); - ret = libexec_vputenvf_noreplace(cmd, fmt, args); - va_end(args); - return ret; -} +extern inline int libexec_putenvf_noreplace(struct libexec_command *, const char *, ...); #else @@ -28,7 +19,7 @@ main(void) ASSERT_EQ_INT(libexec_putenvf_noreplace(NULL, "X=Y"), -1); ASSERT_EQ_INT(errno, EINVAL); - libexec_init_command(&cmd); + cmd = LIBEXEC_COMMAND_INIT; memcpy(&ref, &cmd, sizeof(cmd)); errno = 0; @@ -100,7 +91,7 @@ main(void) libexec_destroy_command(&cmd); - libexec_init_command(&cmd); + cmd = LIBEXEC_COMMAND_INIT; env = environ; environ = calloc(2, sizeof(*environ)); ASSERT_NOT_NULL(environ); -- cgit v1.2.3-70-g09d2