From c57844b08bced71778f38f2346464c3e0836287c Mon Sep 17 00:00:00 2001 From: Mattias Andrée Date: Fri, 1 Nov 2019 22:06:40 +0100 Subject: Add some functions and add functions with _failed suffix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mattias Andrée --- pipe.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) (limited to 'pipe.c') diff --git a/pipe.c b/pipe.c index 3c0fed5..a0cd32f 100644 --- a/pipe.c +++ b/pipe.c @@ -2,19 +2,16 @@ #include "internal.h" -int -liberror_pipe(int fds[2]) +void +liberror_pipe_failed(int fds[2]) { const char *desc; - if (!fds) { - desc = "Output parameter is NULL"; - goto error; - } - if (!pipe(fds)) - return 0; switch (errno) { case EFAULT: - desc = "Output parameter is an invalid pointer"; + if (!fds) + desc = "Output parameter is NULL"; + else + desc = "Output parameter is an invalid pointer"; break; case EMFILE: desc = "The process have too many file descriptors open"; @@ -26,8 +23,17 @@ liberror_pipe(int fds[2]) desc = ""; break; } -error: - liberror_save_backtrace(NULL); liberror_set_error_errno(desc, "pipe", errno); + (void) fds; +} + + +int +liberror_pipe(int fds[2]) +{ + if (!pipe(fds)) + return 0; + liberror_save_backtrace(NULL); + liberror_pipe_failed(fds); return -1; } -- cgit v1.2.3-70-g09d2