From e6aae71bbc65211a38c466dcce4c3d2961543e9a Mon Sep 17 00:00:00 2001 From: Mattias Andrée Date: Wed, 16 Feb 2022 09:40:18 +0100 Subject: Remove todo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit load_block is optimised to a memcpy on little-endian machines, and argon2_blake2b_exthash must (there are less desirable alternatives) write to an intermediate buffer beause it can write beyond the target area Signed-off-by: Mattias Andrée --- libar2_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libar2_hash.c b/libar2_hash.c index 757dbdf..98c50cb 100644 --- a/libar2_hash.c +++ b/libar2_hash.c @@ -518,7 +518,7 @@ libar2_hash(void *hash, void *msg, size_t msglen, struct libar2_argon2_parameter store32(&hash0[64], 0); store32(&hash0[68], (uint_least32_t)i); argon2_blake2b_exthash(block, 1024, hash0, 72); - load_block(&memory[i * lanelen + 0], block); /* TODO this is a copy function on LE-machines */ + load_block(&memory[i * lanelen + 0], block); store32(&hash0[64], 1); argon2_blake2b_exthash(block, 1024, hash0, 72); -- cgit v1.2.3-70-g09d2